From: Thomas Gleixner <tglx@linutronix.de>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, "'Greg KH'" <greg@kroah.com>
Subject: Re: [PATCHv2 10/11] unicore32 core architecture: interrupts ang gpio handling
Date: Wed, 16 Feb 2011 10:25:30 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1102161020470.26192@localhost6.localdomain6> (raw)
In-Reply-To: <02f501cbcb49$015b8fa0$0412aee0$@mprc.pku.edu.cn>
On Sun, 13 Feb 2011, Guan Xuetao wrote:
> +
> +#ifndef __ASSEMBLY__
> +struct irqaction;
Why do you need that ?
> +struct pt_regs;
> +extern void migrate_irqs(void);
What's that for ? Used nowhere AFAICT
> +extern void asm_do_IRQ(unsigned int, struct pt_regs *);
> +
> +#endif
> +static struct irq_chip puv3_low_gpio_chip = {
> + .name = "GPIO-low",
> + .ack = puv3_low_gpio_ack,
Please use irq_* functions. These are deprecated and going away soon.
> + .mask = puv3_low_gpio_mask,
> + .unmask = puv3_low_gpio_unmask,
> + .set_type = puv3_gpio_type,
> + .set_wake = puv3_low_gpio_wake,
> +};
> +
> +static struct irq_chip puv3_normal_chip = {
> + .name = "PKUnity-v3",
> + .ack = puv3_mask_irq,
> + .mask = puv3_mask_irq,
> + .unmask = puv3_unmask_irq,
> + .set_wake = puv3_set_wake,
> +};
Ditto
Thanks,
tglx
next prev parent reply other threads:[~2011-02-16 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 6:41 Guan Xuetao
2011-02-16 9:25 ` Thomas Gleixner [this message]
2011-02-17 11:04 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1102161020470.26192@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®