Re: [PATCH v2] debugobjects: print more data

[Thomas Gleixner <tglx@linutronix.de>]

On Mon, 21 Feb 2011, Stanislaw Gruszka wrote:
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -276,6 +276,7 @@ config TIMER_STATS
>  config DEBUG_OBJECTS
>  	bool "Debug object operations"
>  	depends on DEBUG_KERNEL
> +	select KALLSYMS

Again, we don't enforce kallsyms with DO

>  	help
>  	  If you say Y here, additional code will be inserted into the
>  	  kernel to track the life time of various objects and validate
> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
> index deebcc5..d5fcdeb 100644
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -14,6 +14,7 @@
>  #include <linux/debugfs.h>
>  #include <linux/slab.h>
>  #include <linux/hash.h>
> +#include <linux/kallsyms.h>

Please remove.

>  
>  #define ODEBUG_HASH_BITS	14
>  #define ODEBUG_HASH_SIZE	(1 << ODEBUG_HASH_BITS)
> @@ -253,10 +254,13 @@ static void debug_print_object(struct debug_obj *obj, char *msg)
>  
>  	if (limit < 5 && obj->descr != descr_test) {
>  		limit++;
> -		WARN(1, KERN_ERR "ODEBUG: %s %s (active state %u) "
> -				 "object type: %s\n",
> +		printk(KERN_ERR "ODEBUG: %s %s (active state %u) "
> +				"object type: %s\n",
>  			msg, obj_states[obj->state], obj->astate,
>  			obj->descr->name);
> +		dump_stack();
> +		if (obj->descr->print)
> +			obj->descr->print(obj->object);
>  	}
>  	debug_objects_warnings++;
>  }
> -- 
> 1.7.1
>