mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Pratheesh Gangadhar <pratheesh@ti.com>,
	davinci-linux-open-source@linux.davincidsp.com,
	amit.chatterjee@ti.com, gregkh@suse.de,
	linux-kernel@vger.kernel.org, hjk@hansjkoch.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] PRUSS UIO driver support
Date: Wed, 23 Feb 2011 21:54:19 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1102232153500.2701@localhost6.localdomain6> (raw)
In-Reply-To: <4D6572ED.9020805@mvista.com>

On Wed, 23 Feb 2011, Sergei Shtylyov wrote:
> Hello.
> 
> On 23-02-2011 23:25, Thomas Gleixner wrote:
> 
> > > +	prussio_virt_addr =
> > > +	    ioremap(regs_prussio->start,
> > > +		    regs_prussio->end - regs_prussio->start + 1);
> 
> > Either make those variable names shorter or do:
> 
> >         len = regs_prussio->end - regs_prussio->start + 1;
> 
>    Or even:
> 
> 	len = resource_size(regs_prussio);
> 
> >         prussio_virt_addr = ioremap(regs_prussio->start, len);

Good point. Forgot about that one :)

Thanks,

	tglx

  reply	other threads:[~2011-02-23 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23 13:52 [PATCH v3 0/2] Add " Pratheesh Gangadhar
2011-02-23 13:52 ` [PATCH v3 1/2] " Pratheesh Gangadhar
2011-02-23 13:52   ` [PATCH v3 2/2] Defines DA850/AM18xx/OMAPL1-38 SOC resources used by PRUSS UIO driver Pratheesh Gangadhar
2011-02-23 17:37   ` [PATCH v3 1/2] PRUSS UIO driver support Hans J. Koch
2011-02-24 13:56     ` TK, Pratheesh Gangadhar
2011-02-23 20:25   ` Thomas Gleixner
2011-02-23 20:49     ` Sergei Shtylyov
2011-02-23 20:54       ` Thomas Gleixner [this message]
2011-02-24 13:55         ` TK, Pratheesh Gangadhar
2011-02-24 13:54     ` TK, Pratheesh Gangadhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1102232153500.2701@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=amit.chatterjee@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=gregkh@suse.de \
    --cc=hjk@hansjkoch.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pratheesh@ti.com \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®