mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: J Freyensee <james_p_freyensee@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	gregkh@suse.de, linux-kernel@vger.kernel.org,
	suhail.ahmed@intel.com, christophe.guerard@intel.com
Subject: Re: [PATCH 03/10] Intel PTI implementaiton of MIPI 1149.7.
Date: Mon, 28 Feb 2011 19:36:59 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1102281935260.2701@localhost6.localdomain6> (raw)
In-Reply-To: <1298915213.3156.32.camel@localhost>

On Mon, 28 Feb 2011, J Freyensee wrote:
> On Mon, 2011-02-28 at 10:28 +0100, Arnd Bergmann wrote:
> > > +static struct miscdevice pti_char_driver = {
> > > +	.minor		= MISC_DYNAMIC_MINOR,
> > > +	.name		= CHARNAME,
> > > +	.fops		= &pti_char_driver_ops
> > > +};
> > > +
> > 
> > It's really strange to have both a tty and a character device that have similar
> > operations. Why can't you have the pti_char_driver functionality in the tty driver?
> > 
> 
> Because that is not what the customer wanted and this is why the driver
> is located in misc/ ;-).  

Brilliant argument. Next time you tell us that the customer wanted a
root hole in his driver and that's why you put it there.

What's the fcking technical reason for having a char and a tty device ?

Thanks,

	tglx

      reply	other threads:[~2011-02-28 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 18:06 james_p_freyensee
2011-02-28  9:28 ` Arnd Bergmann
2011-02-28 17:46   ` J Freyensee
2011-02-28 18:36     ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1102281935260.2701@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=christophe.guerard@intel.com \
    --cc=gregkh@suse.de \
    --cc=james_p_freyensee@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suhail.ahmed@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®