mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Cc: davidb@codeaurora.org, dwalker@fifo99.com,
	Samuel Ortiz <sameo@linux.intel.com>,
	Bryan Huntsman <bryanh@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-msm-owner@vger.kernel.org,
	linux-arm-kernel@lists.intradead.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Linus Walleij <linux.walleij@linaro.org>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PM8921 MFD V4 2/6] mfd: pm8xxx: Add irq support
Date: Fri, 18 Mar 2011 09:38:56 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1103180935530.2787@localhost6.localdomain6> (raw)
In-Reply-To: <1300422118-13888-3-git-send-email-adharmap@codeaurora.org>

On Thu, 17 Mar 2011, adharmap@codeaurora.org wrote:
> +static struct irq_chip pm8xxx_irq_chip = {
> +	.name		= "pm8xxx",
> +	.irq_mask_ack	= pm8xxx_irq_mask_ack,
> +	.irq_unmask	= pm8xxx_irq_unmask,
> +	.irq_set_type	= pm8xxx_irq_set_type,
> +	.flags		= IRQCHIP_MASK_ON_SUSPEND,
> +};

Ok, that looks sane now. One problem remains. You have removed the
set_wake function, which will cause the core to bail when an irq is
marked wake. So you want an set_wake() function which does nothing
else than return 0 for now. I'll have a look that we can handle that
case with a chip flag in the core.

Thanks,

	tglx



  reply	other threads:[~2011-03-18  8:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18  4:21 [PM8921 MFD V4 0/6] pm8921 core and subdevices adharmap
2011-03-18  4:21 ` [PM8921 MFD V4 1/6] mfd: pm8921: Add PMIC 8921 core driver adharmap
2011-03-22 19:00   ` Abhijeet Dharmapurikar
2011-03-18  4:21 ` [PM8921 MFD V4 2/6] mfd: pm8xxx: Add irq support adharmap
2011-03-18  8:38   ` Thomas Gleixner [this message]
2011-03-18  4:21 ` [PM8921 MFD V4 3/6] gpio: pm8xxx-gpio: Add pm8xxx gpio driver adharmap
2011-03-18  4:21 ` [PM8921 MFD V4 4/6] mfd: pm8xxx-mpp: Add pm8xxx MPP driver adharmap
2011-03-22 18:45   ` Abhijeet Dharmapurikar
2011-03-18  4:21 ` [PM8921 MFD V4 5/6] MAINTAINERS: Add patterns for pmic 8921 files to MSM subsystem adharmap
2011-03-18  4:21 ` [PM8921 MFD V4 6/6] msm: board-8960: Add support for pm8921 adharmap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1103180935530.2787@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=adharmap@codeaurora.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=bryanh@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=dwalker@fifo99.com \
    --cc=gregkh@suse.de \
    --cc=linux-arm-kernel@lists.intradead.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.walleij@linaro.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®