From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759591Ab1JGIa7 (ORCPT ); Fri, 7 Oct 2011 04:30:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57141 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759308Ab1JGIa5 (ORCPT ); Fri, 7 Oct 2011 04:30:57 -0400 Date: Fri, 7 Oct 2011 10:30:46 +0200 (CEST) From: Lukas Czerner X-X-Sender: lukas@dhcp-27-109.brq.redhat.com To: Joe Perches cc: Fabrice Jouhaud , linux-ext4@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs In-Reply-To: <1317916878.1823.2.camel@Joe-Laptop> Message-ID: References: <1317916276-2509-1-git-send-email-yargil@free.fr> <1317916878.1823.2.camel@Joe-Laptop> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Oct 2011, Joe Perches wrote: > On Thu, 2011-10-06 at 17:51 +0200, Fabrice Jouhaud wrote: > > From: Yargil > > It would be better to use your full name on the "From: " line > > > Regression from commit dd68314ccf3fb918c1fb6471817edbc60ece4b52 > > The problem come from the test of the return value of proc_mkdir > > that is always false without procfs and abort the init of ext4. > > > > Signed-off-by: Fabrice Jouhaud > > --- > > fs/ext4/super.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > > index 44d0c8d..9b51b17 100644 > > --- a/fs/ext4/super.c > > +++ b/fs/ext4/super.c > > @@ -4985,8 +4985,10 @@ static int __init ext4_init_fs(void) > > if (!ext4_kset) > > goto out6; > > ext4_proc_root = proc_mkdir("fs/ext4", NULL); > > +#ifdef CONFIG_PROC_FS > > if (!ext4_proc_root) > > goto out5; > > +#endif > > It would make more sense as: > > +#ifdef CONFIG_PROC_FS > ext4_proc_root = proc_mkdir("fs/ext4", NULL); > if (!ext4_proc_root) > goto out5; > +#endif Actually it does not really matter, important is not to check the condition in case that proc is not configured in. > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --