From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752669Ab2DNMW5 (ORCPT ); Sat, 14 Apr 2012 08:22:57 -0400 Received: from ja.ssi.bg ([178.16.129.10]:43821 "EHLO ja.ssi.bg" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678Ab2DNMWz (ORCPT ); Sat, 14 Apr 2012 08:22:55 -0400 Date: Sat, 14 Apr 2012 15:23:32 +0300 (EEST) From: Julian Anastasov To: Sasha Levin cc: wensong@linux-vs.org, horms@verge.net.au, kaber@trash.net, davem@davemloft.net, davej@redhat.com, netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] netfilter: ipvs: Verify that IP_VS protocol has been registered In-Reply-To: Message-ID: References: <1334409722-26315-1-git-send-email-levinsasha928@gmail.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463811672-151450638-1334406212=:9966" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811672-151450638-1334406212=:9966 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Hello, On Sat, 14 Apr 2012, Sasha Levin wrote: > On Sat, Apr 14, 2012 at 1:53 PM, Julian Anastasov wrote: > >        Ops. It seems now we expose old problem when > > no protocol is configured. As this change probably will > > go to stable kernels, lets make it correct. Can you > > remove the defines around register_ip_vs_proto_netns, so > > that it is always compiled. One that wants to save > > memory will not disable all protocols. See commit > > 091bb34c143674d37a59b2d4857534f7106c5d7d for reference. > > Oh, so it wasn't getting built right now at all if we didn't select > any protocols. > > How about moving those defines down to our loop as well? this way > everything will behave exactly like it did before. Better to remove the defines. It is a misconfiguration to enable IPVS without protocols. The referenced commit just tried to remove warnings, not save memory by commenting unused function. Adding more define makes the things more ugly. Regards -- Julian Anastasov ---1463811672-151450638-1334406212=:9966--