From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755974Ab2JCNrM (ORCPT ); Wed, 3 Oct 2012 09:47:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132Ab2JCNrJ (ORCPT ); Wed, 3 Oct 2012 09:47:09 -0400 Date: Wed, 3 Oct 2012 15:46:54 +0200 (CEST) From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= X-X-Sender: lukas@dhcp-1-104.brq.redhat.com To: Douglas Gilbert cc: "Martin K. Petersen" , Lukas Czerner , linux-scsi@vger.kernel.org, JBottomley@parallels.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi_debug: Fix off-by-one bug when unmapping region In-Reply-To: <5047AAD9.90106@interlog.com> Message-ID: References: <1345127925-32042-1-git-send-email-lczerner@redhat.com> <5047AAD9.90106@interlog.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Sep 2012, Douglas Gilbert wrote: > Date: Wed, 05 Sep 2012 15:41:13 -0400 > From: Douglas Gilbert > To: Martin K. Petersen > Cc: Lukas Czerner , linux-scsi@vger.kernel.org, > JBottomley@parallels.com, tytso@mit.edu, pbonzini@redhat.com, > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] scsi_debug: Fix off-by-one bug when unmapping region > > On 12-08-17 12:11 PM, Martin K. Petersen wrote: > > > > > > > "Lukas" == Lukas Czerner writes: > > > > Lukas> Currently it is possible to unmap one more block than user > > Lukas> requested to due to the off-by-one error in unmap_region(). This > > Lukas> is probably due to the fact that the end variable despite its > > Lukas> name actually points to the last block to unmap + 1. However in > > Lukas> the condition it is handled as the last block of the region to > > Lukas> unmap. > > > > Acked-by: Martin K. Petersen > > Acked-by: Douglas Gilbert James, could you please pick this one ? Thanks! -Lukas