From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbbCWKa5 (ORCPT ); Mon, 23 Mar 2015 06:30:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52492 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752097AbbCWKa4 (ORCPT ); Mon, 23 Mar 2015 06:30:56 -0400 Date: Mon, 23 Mar 2015 11:30:44 +0100 (CET) From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= X-X-Sender: lczerner@localhost.localdomain To: Wei Yuan cc: jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, lizefan@huawei.com Subject: Re: [PATCH] ext3: Remove useless condition in if statement. In-Reply-To: <1426820950-4720-1-git-send-email-weiyuan.wei@huawei.com> Message-ID: References: <1426820950-4720-1-git-send-email-weiyuan.wei@huawei.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Mar 2015, Wei Yuan wrote: > Date: Fri, 20 Mar 2015 11:09:10 +0800 > From: Wei Yuan > To: jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca > Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, > lczerner@redhat.com, lizefan@huawei.com > Subject: [PATCH] ext3: Remove useless condition in if statement. > > In this if statement, the previous condition is useless, the later one has covered it. Nice that you've send this ext3 counterpart for ext4 patch. Thanks! Reviewed-by: Lukas Czerner > > Signed-off-by: Weiyuan > --- > fs/ext3/xattr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c > index c6874be..24215dc 100644 > --- a/fs/ext3/xattr.c > +++ b/fs/ext3/xattr.c > @@ -546,8 +546,7 @@ ext3_xattr_set_entry(struct ext3_xattr_info *i, struct ext3_xattr_search *s) > free += EXT3_XATTR_LEN(name_len); > } > if (i->value) { > - if (free < EXT3_XATTR_SIZE(i->value_len) || > - free < EXT3_XATTR_LEN(name_len) + > + if (free < EXT3_XATTR_LEN(name_len) + > EXT3_XATTR_SIZE(i->value_len)) > return -ENOSPC; > } >