From: Linus Torvalds <torvalds@linux-foundation.org>
To: Robin Holt <holt@sgi.com>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
systemtap@sources.redhat.com,
Harvey Harrison <harvey.harrison@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Jan Blunck <jblunck@suse.de>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH -rc] [BUGFIX] x86: fix kernel_trap_sp()
Date: Tue, 12 May 2009 07:36:07 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0905120732580.3586@localhost.localdomain> (raw)
In-Reply-To: <20090512112300.GL7601@sgi.com>
On Tue, 12 May 2009, Robin Holt wrote:
> > */
> > -static inline unsigned long kernel_trap_sp(struct pt_regs *regs)
> > +static inline unsigned long kernel_stack_pointer(struct pt_regs *regs)
>
> Why not have it return an unsigned long *?
I considered it, but since part of the point of the patch was to make it
look like the mirror of "user_stack_pointer()", returning "unsigned long"
looked more appropriate.
But I have no really strong opinions. I wouldn't object to making it
return "unsigned long *" either.
Linus
next prev parent reply other threads:[~2009-05-12 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 21:03 Masami Hiramatsu
2009-05-11 21:51 ` [tip:x86/urgent] x86, 32-bit: " tip-bot for Masami Hiramatsu
2009-05-11 22:24 ` [PATCH -rc] [BUGFIX] x86: " Linus Torvalds
2009-05-11 22:40 ` Ingo Molnar
2009-05-11 22:52 ` Linus Torvalds
2009-05-12 11:23 ` Robin Holt
2009-05-12 14:20 ` Masami Hiramatsu
2009-05-12 14:36 ` Linus Torvalds [this message]
2009-05-11 22:39 ` [tip:x86/urgent] x86, 32-bit: " tip-bot for Masami Hiramatsu
2009-05-11 22:42 ` tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0905120732580.3586@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=hch@infradead.org \
--cc=holt@sgi.com \
--cc=jblunck@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=systemtap@sources.redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome