From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272AbZFGX5t (ORCPT ); Sun, 7 Jun 2009 19:57:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752734AbZFGX5k (ORCPT ); Sun, 7 Jun 2009 19:57:40 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48509 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbZFGX5j (ORCPT ); Sun, 7 Jun 2009 19:57:39 -0400 Date: Sun, 7 Jun 2009 16:57:19 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Bartlomiej Zolnierkiewicz cc: Pekka Enberg , James Bottomley , Alan Cox , Andrew Morton , Stephen Rothwell , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [git pull] IDE fixes In-Reply-To: <200906080147.12274.bzolnier@gmail.com> Message-ID: References: <200906071444.33047.bzolnier@gmail.com> <200906072125.40784.bzolnier@gmail.com> <200906080147.12274.bzolnier@gmail.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Jun 2009, Bartlomiej Zolnierkiewicz wrote: > > This is not a new feature and basing your opinions on opinions of people > who don't read the code before commenting is bad, really bad, m'kay? The thing is, I had planned on doing a final release yesterday, even before your pull came in. I decided to hold off, let it be, just to test the _current_ state a bit more. No way am I then adding some effectively totally untested new code-path. And if you start messing in partitions.c and adding whole new callback functions to generic block_device_operations, then that's a new code-path. The IDE subsystem has _no_ business adding random new callbacks in the very last days of a release. It sure as hell is not just a bugfix, it's a new feature. The feature may be _needed_ for some specific bug report, but that is totally irrelevant. We don't do things like that. It's also almost certainly not a regression, is it? So by no measure does it work as a "late in the -rc sequence" patch. Linus