From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Tejun Heo <tj@kernel.org>, Steven Rostedt <srostedt@redhat.com>,
Li Zefan <lizf@cn.fujitsu.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] first block round for 2.6.31
Date: Thu, 11 Jun 2009 11:42:04 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0906111134180.3573@localhost.localdomain> (raw)
In-Reply-To: <20090611182657.GY11363@kernel.dk>
On Thu, 11 Jun 2009, Jens Axboe wrote:
>
> > Btw, Jens: in your tree, you've committed Tejun's changes without adding
> > your own sign-off. Not good!
>
> That's for the patches that I pulled from his git tree. It should list
> him as committer too.
NO!
It sounds like you have done a _major_ no-no, which is to pull from his
tree, and then rebase it.
DO NOT DO THAT! NOT EVER!
If you pull from somebody elses tree, you can no longer touch the commit.
It absolutely has to stay the same. Otherwise we see this kind of insane
duplication.
You're doing something seriously wrong here. I wrote a long rant about
what the rules were last release cycle, but now I can't find it.
Basically, if you're not the committer, you really must never EVER touch
it.
[ Anybody with enough google-fu to find my rant, so I don't have to
re-rant? ]
Linus
next prev parent reply other threads:[~2009-06-11 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 11:13 Jens Axboe
2009-06-11 18:18 ` Linus Torvalds
2009-06-11 18:26 ` Jens Axboe
2009-06-11 18:42 ` Linus Torvalds [this message]
2009-06-11 18:52 ` Jens Axboe
2009-06-11 19:23 ` Linus Torvalds
2009-06-11 20:04 ` Jens Axboe
2009-06-11 19:58 ` Diego Calleja
2009-06-11 20:05 ` Linus Torvalds
2009-06-12 6:48 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0906111134180.3573@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=srostedt@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome