From: Linus Torvalds <torvalds@linux-foundation.org>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] voltage regulator updates for 2.6.31-rc1
Date: Mon, 15 Jun 2009 09:29:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0906150927390.3305@localhost.localdomain> (raw)
In-Reply-To: <1245065061.21421.90.camel@vega.slimlogic.co.uk>
On Mon, 15 Jun 2009, Liam Girdwood wrote:
>
> drivers/regulator/lp3971.c | 562 ++++++++++++++++++++++++++
> include/linux/regulator/lp3971.h | 51 +++
So I really don't like this.
Why the heck would "lp3971.h" be under "include/linux"? That makes no
sense what-so-ever.
Why isn't it just
drivers/regulator/lp3971.c
drivers/regulator/lp3971.h
instead? There is never any reason for anything but the lp3971 driver to
include its own header file, they should _not_ be split up to be in two
different places.
In fact, why do we have a "include/linux/regulator/" at all? Does anybody
else ever care? I doubt it.
Anyway, I pulled it, but I think this needs to be fixed.
Linus
next prev parent reply other threads:[~2009-06-15 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 11:24 Liam Girdwood
2009-06-15 16:29 ` Linus Torvalds [this message]
2009-06-15 17:17 ` Mark Brown
2009-06-15 17:28 ` Linus Torvalds
2009-06-15 18:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0906150927390.3305@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®