From: Linus Torvalds <torvalds@linux-foundation.org>
To: Eric Paris <eparis@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeremy Kerr <jk@ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] notification tree - fsnotify assumes incorrectly positive parent dentry
Date: Mon, 29 Jun 2009 13:09:09 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0906291305030.3605@localhost.localdomain> (raw)
In-Reply-To: <1246305712.754.292.camel@dhcp235-23.rdu.redhat.com>
On Mon, 29 Jun 2009, Eric Paris wrote:
>
> Linus please consider pulling from the notification tree. There is one
> patch in the tree which should fix an issue in which fsnotify assumed
> that dentry->d_parent->d_inode != NULL. This turns out to be false for
> spufs and causes a panic.
Hmm. It does sound like a reasonable assumption, though. Maybe spufs
should be fixed to have an inode for all directories?
A NULL d_inode means that something is a negative dentry, and a negative
dentry shouldn't have children.
Added a few ppc people to the cc.
I'll pull the fix, but I really think it sounds like spufs is doing
something wrong here.
Linus
next prev parent reply other threads:[~2009-06-29 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 20:01 Eric Paris
2009-06-29 20:09 ` Linus Torvalds [this message]
2009-06-30 0:46 ` Jeremy Kerr
2009-06-30 1:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0906291305030.3605@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=eparis@redhat.com \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®