From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbZHXTXi (ORCPT ); Mon, 24 Aug 2009 15:23:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753266AbZHXTXi (ORCPT ); Mon, 24 Aug 2009 15:23:38 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41876 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753104AbZHXTXh (ORCPT ); Mon, 24 Aug 2009 15:23:37 -0400 Date: Mon, 24 Aug 2009 12:23:19 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Eric Paris cc: Frans Pop , linux-kernel@vger.kernel.org, linux-fs-devel@vger.kernel.org, zdenek.kabelac@gmail.com, christoph.thielecke@gmx.de, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, grant.wilson@zen.co.uk, mikko.cal@gmail.com Subject: Re: [PATCH 2/3] inotify: do not BUG on idr entries at inotify destruction In-Reply-To: <1251140949.25096.16.camel@dhcp231-106.rdu.redhat.com> Message-ID: References: <20090824173524.14196.25992.stgit@paris.rdu.redhat.com> <20090824173524.14196.25992.stgit@paris.rdu.redhat.com> <20090824173812.14196.381.stgit@paris.rdu.redhat.com> <200908242034.50885.elendil@planet.nl> <1251140949.25096.16.camel@dhcp231-106.rdu.redhat.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Aug 2009, Eric Paris wrote: > > You suspect correctly. :( I'll fix in my tree before I request a > pull.... Can you change the WARN() to a WARN_ONCE() too. Generally, we prefer the "ONCE" variant if there isn't some intrisic reason why we'd want to know about each event. If there is some load that triggers this, do you care about _how_many_times_ it happens, or about the fact that it happens in the first place? In this case, I think it's the "happens in the first place" case - once you see it a single time, the rest of the reports aren't that interesting. And using the ONCE thing means that we know it's not going to spam the logs. Linus