Re: Linux 2.6.31-rc7

[Linus Torvalds <torvalds@linux-foundation.org>]

On Wed, 26 Aug 2009, Zhenyu Wang wrote:
> 
> We can't depend on any BIOS display config as you noted before our driver.

But you do. You depend on the even _less_ reliable existence of a VBT 
table.

> And our driver does more flexible config than VBIOS does.

If by "flexible" you mean "doesn't work in many more ways", then yes.

I have never EVER found a BIOS that didn't output to at least _some_ 
screen that is connected. That's fairly damn fundamental. Yet that is 
exactly what KMS screws up on some hardware right now.

Trust me, "flexible" is not the right word. 

> We know we have problem on Mac mini, this issue has been known for a while.
> And Keith also posted patch at
> 	http://lists.freedesktop.org/archives/intel-gfx/2009-June/002843.html
> but I don't know the status of this now.

And how about MacBook 2.1, which apparently also goes black?

And the Westmere thing? 

> We've tried many ways to detect LVDS, but none is stable or actually work for
> every chip. But now we have DMI quirks for some known no LVDS machine (including
> Mac mini), and we detect through ACPI LID object for LVDS exist. 

And dammit, if you cannot detect it, then don't try.

You'd actually be better off not trying your random crud, and instead
 - leave whatever connection the BIOS set up
 - let the user _tell_ you about other ones.

If you cannot reliably detect something, don't go off and use some random 
number generator. And quite frankly, depending on BIOS tables _is_ a 
random number generator. It may be that you just haven't learnt that yet, 
but maybe you could work on ACPI for a while to see what I mean.

Right now, there's not even any way to _override_ your incorrect guesses. 

So I can say "don't do mode-setting at all", but I can't say "use SVDO at 
1680x1050". So my screen goes black. And I happen to be in the enviable 
position of having known about the Mac Mini issues and the KMS thing - 
think about what happens to people that just try a new distro kernel, and 
suddenly there's nothing on the screen. 

			Linus