From: Linus Torvalds <torvalds@linux-foundation.org>
To: Anirban Sinha <ASinha@zeugmasystems.com>
Cc: linux-kernel@vger.kernel.org, Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] cleanup legacy console_print function
Date: Mon, 14 Sep 2009 07:50:47 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0909140749300.3654@localhost.localdomain> (raw)
In-Reply-To: <DDFD17CC94A9BD49A82147DDF7D545C501F0FD30@exchange.ZeugmaSystems.local>
On Fri, 11 Sep 2009, Anirban Sinha wrote:
>
> - console_print(text); \
> - console_print("\n"); \
> + printk(KERN_EMERG "%s", text); \
> + printk(KERN_EMERG "\n"); \
Just clean it up to be
printk(KERN_EMERG "%s\n", text);
instead while at it.
> #define TRACE_CHR(chr) \
> { \
> if(dtlk_trace) \
> - console_print(chr); \
> + printk(KERN_EMERG "%c", chr); \
That can't be right. The translation is to use "%s", not "%c".
Linus
next prev parent reply other threads:[~2009-09-14 14:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 23:47 [PATCH] console_print: change the function api to make it have printk style interface Anirban Sinha
2009-08-26 0:18 ` Linus Torvalds
2009-08-26 0:28 ` Anirban Sinha
2009-08-26 0:39 ` Linus Torvalds
2009-08-26 0:57 ` Anirban Sinha
2009-08-26 0:26 ` Randy Dunlap
2009-08-26 20:05 ` Anirban Sinha
2009-08-27 19:34 ` Linus Torvalds
2009-08-27 21:36 ` Anirban Sinha
2009-09-11 19:29 ` [PATCH] cleanup legacy console_print function Anirban Sinha
2009-09-14 14:50 ` Linus Torvalds [this message]
2009-09-14 17:18 ` Anirban Sinha
2009-09-14 18:28 Anirban Sinha
2009-09-15 17:27 ` Bjorn Helgaas
2009-09-15 17:55 ` Anirban Sinha
2009-09-15 18:00 ` Tony Luck
2009-09-15 18:05 ` Anirban Sinha
2009-09-15 18:11 ` Luck, Tony
2009-09-15 18:25 ` Anirban Sinha
2009-09-15 18:39 ` Tony Luck
2009-09-15 19:08 ` Anirban Sinha
2009-09-15 15:54 Anirban Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0909140749300.3654@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=ASinha@zeugmasystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®