mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Greg KH <gregkh@suse.de>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [crash] NULL pointer dereference at IP: [<ffffffff812e9ccb>] uart_close+0x2a/0x1e4
Date: Mon, 12 Oct 2009 09:19:28 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.01.0910120850590.3438@localhost.localdomain> (raw)
In-Reply-To: <20091012080511.GA22607@elte.hu>



On Mon, 12 Oct 2009, Ingo Molnar wrote:
> 
> Note, i have your fix below applied in tip:out-of-tree - it might be the 
> source of this bug? (If yes then this isnt an .32-rc4 problem.)

If yes (but you later reported no), it would still be a 32-rc4 problem, 
because that patch got committed as 0b5759c654 ("tty: Avoid dropping 
ldisc_mutex over hangup tty re-initialization").

So you shouldn't need it in the out-of-tree branch any more, and you 
probably just never noticed because it all merged cleanly.

Commit 46d57a449 (which you then bisected to) looks really irritating, 
since it just renamed variables in annoying ways (ie the old "port" is now 
"uport", and there's a new "port" that means something else). That thing 
should have been split up to do the renaming separately, so that a mis-use 
of "port" would have caused a compile error.

I'm not seeing anything obvious. Alan obviously found one bug already.

		Linus

  parent reply	other threads:[~2009-10-12 16:21 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11 21:58 Linux 2.6.32-rc4 Linus Torvalds
2009-10-12  7:42 ` [origin tree build failure] [PATCH] Revert "USB: musb: make HAVE_CLK support optional" Ingo Molnar
2009-10-12 13:05   ` Mike Frysinger
2009-10-12 14:29     ` Greg KH
2009-10-12 14:39       ` Mike Frysinger
2009-10-12 15:00         ` Ingo Molnar
2009-10-12 15:09           ` Mike Frysinger
2009-10-12 13:49   ` [PATCH] USB: musb: invert arch depend string Mike Frysinger
2009-10-12 14:28     ` Greg KH
2009-10-12 15:02       ` Ingo Molnar
2009-10-12  8:05 ` [crash] NULL pointer dereference at IP: [<ffffffff812e9ccb>] uart_close+0x2a/0x1e4 Ingo Molnar
2009-10-12  9:19   ` Ingo Molnar
2009-10-12  9:27     ` Ingo Molnar
2009-10-12 11:25       ` Ingo Molnar
2009-10-12 11:45         ` Alan Cox
2009-10-12 11:55           ` Ingo Molnar
2009-10-12 12:22             ` Ingo Molnar
2009-10-12 13:06               ` Alan Cox
2009-10-12 14:23                 ` Ingo Molnar
2009-10-12 16:19   ` Linus Torvalds [this message]
2009-10-12 16:26     ` Ingo Molnar
2009-10-12 16:28     ` Ingo Molnar
2009-10-12 16:37     ` Linus Torvalds
2009-10-12 17:13       ` [PATCH] tty, serial: Fix race and NULL check in uart_close() Ingo Molnar
2009-10-12  8:29 ` Linux 2.6.32-rc4 Ingo Molnar
2009-10-12  8:30   ` [origin tree build failure] [PATCH] headers: Fix build in drivers/pci/hotplug/cpqphp.h Ingo Molnar
2009-10-12  8:32   ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/rtc.c Ingo Molnar
2009-10-12  8:40   ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/pci200syn.c Ingo Molnar
2009-10-12  9:11   ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/n2.c Ingo Molnar
2009-10-12  9:16   ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/c101.c Ingo Molnar
2009-10-12 10:06   ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/genrtc.c Ingo Molnar
2009-10-12 13:29   ` Linux 2.6.32-rc4 Alexey Dobriyan
2009-10-12  9:43     ` Ingo Molnar
2009-10-12 13:34   ` Alexey Dobriyan
2009-10-12  9:48     ` Ingo Molnar
2009-10-12 14:22   ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/sonypi.c Ingo Molnar
2009-10-12 13:01 ` Linux 2.6.32-rc4 Thomas Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.01.0910120850590.3438@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®