From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932086Ab1ALEzr (ORCPT ); Tue, 11 Jan 2011 23:55:47 -0500 Received: from vms173005pub.verizon.net ([206.46.173.5]:50318 "EHLO vms173005pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754077Ab1ALEzp (ORCPT ); Tue, 11 Jan 2011 23:55:45 -0500 Date: Tue, 11 Jan 2011 23:55:24 -0500 (EST) From: Len Brown X-X-Sender: lenb@x980 To: Huang Ying Cc: "linux-kernel@vger.kernel.org" , Andi Kleen , Tony Luck , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH] ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI notification type support In-reply-to: <1294362425.18956.7.camel@yhuang-dev> Message-id: References: <1294362425.18956.7.camel@yhuang-dev> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > if (error_block_length > GHES_ESTATUS_MAX_SIZE) { >- pr_warning(FW_WARN GHES_PFX >- "Error status block length is too long: %u for " >- "generic hardware error source: %d.\n", >+ pr_warning( >+FW_WARN GHES_PFX "Error status block length is too long: %u for \n" >+"generic hardware error source: %d.\n", > error_block_length, generic->header.source_id); > error_block_length = GHES_ESTATUS_MAX_SIZE; Hi Ying, I assume that you are tweaking these pr_warning() lines to beautify the output, but as far as source code readability, I liked the previous syntax better. Although maintainer's opinions vary, I generally do not strictly enforce the 80 column rule for printk strings. Ie. I think that code readability with good whitespace indentation plus printk string grep-ability are more important than strictly fitting within 80-columns. thanks, Len Brown, Intel Open Source Technology Center