mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
	Witold Baryluk <baryluk@smp.if.uj.edu.pl>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH] ftrace: Add internal recursive checks
Date: Wed, 25 May 2011 20:57:25 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1105252054270.3078@ionos> (raw)
In-Reply-To: <1306348063.1465.116.camel@gandalf.stny.rr.com>

On Wed, 25 May 2011, Steven Rostedt wrote:
> +
> +	/* Only current can touch these values */
> +#define trace_recursion_inc() (current)->trace_recursion++
> +#define trace_recursion_dec() (current)->trace_recursion--
> +	/* Ring buffer has the 10 LSB bits to count */
> +#define trace_recursion_buffer() ((current)->trace_recursion & 0x3ff)
> +#define TRACE_INTERNAL_BIT		(1<<11)
> +#define TRACE_GLOBAL_BIT		(1<<12)
> +#define trace_recursion_set(bit)	(current)->trace_recursion |= (bit)
> +#define trace_recursion_clear(bit)	(current)->trace_recursion &= ~(bit)
> +#define trace_recursion_test(bit)	((current)->trace_recursion & (bit))
> +
>  #endif /* CONFIG_TRACING */

Bah, these are only used in kernel/trace/. So can you please add them
to a kernel/trace local header file instead of cramming it mindlessly
into task_struct just because you're lazy?

Thanks,

	tglx

  reply	other threads:[~2011-05-25 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25 18:27 Steven Rostedt
2011-05-25 18:57 ` Thomas Gleixner [this message]
2011-05-25 20:23   ` Steven Rostedt
2011-05-25 22:54     ` Thomas Gleixner
2011-05-25 23:41       ` Steven Rostedt
2011-05-25 23:47         ` Steven Rostedt
2011-05-27 12:48 ` [tip:perf/urgent] " tip-bot for Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1105252054270.3078@ionos \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=baryluk@smp.if.uj.edu.pl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome