From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756297Ab1EYVky (ORCPT ); Wed, 25 May 2011 17:40:54 -0400 Received: from www.linutronix.de ([62.245.132.108]:44988 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753661Ab1EYVkw (ORCPT ); Wed, 25 May 2011 17:40:52 -0400 Date: Wed, 25 May 2011 23:40:36 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: Ingo Molnar , Andi Kleen , x86@kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" Subject: Re: [PATCH 1/3] x86, intel: Output microcode revision v2 In-Reply-To: <20110525200606.GA23597@tassilo.jf.intel.com> Message-ID: References: <1306351948-23382-1-git-send-email-andi@firstfloor.org> <20110525195251.GA31268@elte.hu> <20110525200606.GA23597@tassilo.jf.intel.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andi, On Wed, 25 May 2011, Andi Kleen wrote: > > You ignored the majority of the review suggestions i gave you in the > > previous thread, and you know that i won't apply your patches without > > you addressing all feedback. > > Huh? I addressed all suggestions that I didn't explicitely > reject (which were few) > > At least to my knowledge. If I missed something that I didn't > reject please point it out. Ingo has politely asked you to change the patches and he gave very detailed advise. Now he pointed out that you ignored most of it. So instead of sitting down and rereading the thread you want Ingo to do your homework and repeat what he already told you ? You seem to believe that requests from maintainers are just random noise, which you can decide to reject or ignore depending on your personal preference. There is no such concept neither for you nor for anybody else. Thanks, tglx