From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751649Ab1GWH3Y (ORCPT ); Sat, 23 Jul 2011 03:29:24 -0400 Received: from www.linutronix.de ([62.245.132.108]:38634 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886Ab1GWH3R (ORCPT ); Sat, 23 Jul 2011 03:29:17 -0400 Date: Sat, 23 Jul 2011 09:29:08 +0200 (CEST) From: Thomas Gleixner To: Sven-Thorsten Dietrich cc: Andrew Morton , =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= , Andrew Chew , linux-rt-users@vger.kernel.org, Alessandro Zummo , linux-kernel@vger.kernel.org, jkastner@redhat.com Subject: Re: [PATCH] rtc-tegra: properly initialize spinlock In-Reply-To: <58E25CAF-EAC4-4613-81B2-D713F5DC8CEF@gmail.com> Message-ID: References: <1311323756-18013-1-git-send-email-u.kleine-koenig@pengutronix.de> <20110722151338.9b1e9594.akpm@linux-foundation.org> <58E25CAF-EAC4-4613-81B2-D713F5DC8CEF@gmail.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Jul 2011, Sven-Thorsten Dietrich wrote: > > On Jul 22, 2011, at 3:13 PM, Andrew Morton wrote: > > > On Fri, 22 Jul 2011 10:35:56 +0200 > > Uwe Kleine-K__nig wrote: > > > >> Using __SPIN_LOCK_UNLOCKED for a dynamically allocated lock is wrong and > >> breaks with PREEMPT_RT_FULL. > > > > Please define "breaks". Lockdep warnings? Deadlocks? > > Narrr, I think its a compile-time problem with the static initializer. Correct. The macro expansion magic of the static initializer barfs and with lockdep the lockdep key assignment is missing. Thanks, tglx