From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757673Ab1IATOr (ORCPT ); Thu, 1 Sep 2011 15:14:47 -0400 Received: from www.linutronix.de ([62.245.132.108]:51253 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757624Ab1IATOq (ORCPT ); Thu, 1 Sep 2011 15:14:46 -0400 Date: Thu, 1 Sep 2011 21:14:42 +0200 (CEST) From: Thomas Gleixner To: John Kacur cc: rt-users , Peter Zijlstra , lkml Subject: Re: [PATCH] PREEMPT_RT_FULL Build error fix In-Reply-To: <1314360393-13605-1-git-send-email-jkacur@redhat.com> Message-ID: References: <1314360393-13605-1-git-send-email-jkacur@redhat.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-222593702-1314904483=:2723" X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-222593702-1314904483=:2723 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 26 Aug 2011, John Kacur wrote: > Problem: > make O=/bld/3.0.3-rt11/ kernel/fork.o > /home/jkacur/jk-2.6/kernel/fork.c:91: error: section of ‘name’ conflicts with previous declaration > > __cacheline_aligned is already part of the definition of DEFINE_RWLOCK > for -rt > > However it is not always used for the tasklist_lock in non-rt, so it can't > simply be added to the definition of DEFINE_RWLOCK in non-rt, so I modified > the definition in fork.c -ENOPARSE The real question is whether RWLOCKS should be cacheline aligned in general or the RT addon is just overkill. Slapping an ifdef around does not answer that. Thanks, tglx --8323328-222593702-1314904483=:2723--