From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] clockevents: Use an atomic RCU notifier for clockevents
Date: Wed, 7 Sep 2011 01:19:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1109070113090.2723@ionos> (raw)
In-Reply-To: <20110906224228.GA5534@alboin.fm.intel.com>
On Tue, 6 Sep 2011, Andi Kleen wrote:
> > The idle code, at least the one in drivers/idle/intel_idle.c, does
> > _NOT_ call into that code at all when a reliable lapic timer is
> > available:
>
> But the ACPI idle doesn't check that, so it still has a scalability problem.
>
> Hmm ok so could add that check into acpi idle too I guess, but then ACPI
> idle doesn't normally know anything about CPUs.
>
> > Either you are using different code or your machine does not have that
> > ARAT flag set.
>
> The second test was using ACPI idle.
And as I said in that very same mail:
> > Same applies for drivers/acpi/processor_idle.c
lapic_timer_check_state()
{
if (cpu_has(&cpu_data(pr->id), X86_FEATURE_ARAT))
return;
....
WTF are you talking about?
Thanks,
tglx
next prev parent reply other threads:[~2011-09-06 23:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 21:08 Andi Kleen
2011-08-29 21:08 ` [PATCH 2/3] broadcast-tick: Move oneshot broadcast mask to per cpu variables v2 Andi Kleen
2011-09-06 15:28 ` Thomas Gleixner
2011-08-29 21:08 ` [PATCH 3/3] tick-broadcast: push down tick_broadcast_lock Andi Kleen
2011-09-06 16:19 ` Thomas Gleixner
2011-09-06 17:49 ` Andi Kleen
2011-09-06 18:55 ` Thomas Gleixner
2011-09-06 19:23 ` [PATCH 1/3] clockevents: Use an atomic RCU notifier for clockevents Thomas Gleixner
2011-09-06 20:33 ` Andi Kleen
2011-09-06 21:45 ` Thomas Gleixner
2011-09-06 22:42 ` Andi Kleen
2011-09-06 23:19 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-26 22:32 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1109070113090.2723@ionos \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome