From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Clark Williams <clark@redhat.com>
Subject: Re: [PATCH][RT] ring-buffer: Convert reader_lock from raw_spin_lock into spin_lock
Date: Tue, 27 Sep 2011 20:21:10 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1109272020060.2711@ionos> (raw)
In-Reply-To: <1317146210.26514.33.camel@gandalf.stny.rr.com>
On Tue, 27 Sep 2011, Steven Rostedt wrote:
> + /*
> + * If an NMI die dumps out the content of the ring buffer
> + * do not grab locks. We also permanently disable the ring
> + * buffer too. A one time deal is all you get from reading
> + * the ring buffer from an NMI.
> + */
> + if (!ok_to_lock()) {
> + if (spin_trylock_irqsave(&cpu_buffer->reader_lock, *flags))
> + return 1;
> + printk("Dumping ring buffer from unsafe context\n");
> + printk("Disabling new ring buffer writes\n");
And what exaclty is the point of these printks/ Aside of that they are
missing KERN_WTF before the string.
Thanks,
tglx
prev parent reply other threads:[~2011-09-27 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 17:56 Steven Rostedt
2011-09-27 18:21 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1109272020060.2711@ionos \
--to=tglx@linutronix.de \
--cc=clark@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®