From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756334Ab1KHTJF (ORCPT ); Tue, 8 Nov 2011 14:09:05 -0500 Received: from relais.videotron.ca ([24.201.245.36]:21901 "EHLO relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753920Ab1KHTJE (ORCPT ); Tue, 8 Nov 2011 14:09:04 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: TEXT/PLAIN; CHARSET=US-ASCII Date: Tue, 08 Nov 2011 14:08:58 -0500 (EST) From: Nicolas Pitre To: Stephen Boyd Cc: David Brown , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv3 2/2] msm: Support DEBUG_LL on MSM8660 and MSM8960 In-reply-to: <1320777184-22446-3-git-send-email-sboyd@codeaurora.org> Message-id: References: <1320777184-22446-1-git-send-email-sboyd@codeaurora.org> <1320777184-22446-3-git-send-email-sboyd@codeaurora.org> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Nov 2011, Stephen Boyd wrote: > Add support for DEBUG_LL on the 8660 and 8960 development boards. > While we're here cleanup the uncompress.h code a bit. Avoid > the use of readl/writel as those are Linux specific APIs that > aren't guaranteed to work in the decompressor. > > Cc: Nicolas Pitre > Signed-off-by: Stephen Boyd Acked-by: Nicolas Pitre Independently from this patch, I was wondering about this code: > + .macro senduart, rd, rx > +#ifdef CONFIG_MSM_HAS_DEBUG_UART_HS > + @ Write the 1 character to UARTDM_TF > + str \rd, [\rx, #0x70] > +#else > teq \rx, #0 > strne \rd, [\rx, #0x0C] > +#endif > .endm Why testing for zero in the #else part? The upper level code should never call this macro with a null byte. Nicolas