From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754928Ab1KIM0D (ORCPT ); Wed, 9 Nov 2011 07:26:03 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:42006 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352Ab1KIM0A (ORCPT ); Wed, 9 Nov 2011 07:26:00 -0500 Date: Wed, 9 Nov 2011 14:25:50 +0200 (EET) From: Pekka Enberg X-X-Sender: penberg@tux.localdomain To: "Michael S. Tsirkin" cc: Sasha Levin , Rusty Russell , lkml - Kernel Mailing List , Alexey Kardashevskiy , Amit Shah , Christian Borntraeger , Krishna Kumar , Pawel Moll , Wang Sheng-Hui , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, avi@redhat.com, penberg@cs.helsinki.fi Subject: Re: [PATCH RFC] virtio-spec: flexible configuration layout In-Reply-To: <20111109101318.GB20612@redhat.com> Message-ID: References: <87wrbkvh3v.fsf@rustcorp.com.au> <20111101114542.GA13434@redhat.com> <1320150813.3847.24.camel@lappy> <20111101124223.GA14060@redhat.com> <8739e7uy87.fsf@rustcorp.com.au> <20111102233110.GA20289@redhat.com> <20111108214021.GA4538@redhat.com> <1320828366.31056.16.camel@lappy> <20111109101318.GB20612@redhat.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Nov 2011, Michael S. Tsirkin wrote: >> KVM tool actually has support for 64bit features, we can probably remove >> that when Pekka isn't looking :) > > It's not yet released so maybe it's not an issue yet. > If it's too late I can re-add them to legacy too. > > Pekka, 64 features aren't yet used and we are discussing > changing the layout for that field. Mind taking it out > of kvm tool for now? Sasha, why did we add 64-bit features to the KVM tool? Wasn't it part of the virtio spec? Does QEMU not use them? How badly will older versions of the KVM tool break if you drop 64-bit features? Pekka