From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932113Ab1KOSt4 (ORCPT ); Tue, 15 Nov 2011 13:49:56 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:57752 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752986Ab1KOStz (ORCPT ); Tue, 15 Nov 2011 13:49:55 -0500 Date: Tue, 15 Nov 2011 20:49:35 +0200 (EET) From: Pekka Enberg X-X-Sender: penberg@tux.localdomain To: Yong Zhang cc: Shaohua Li , Christoph Lameter , Julie Sullivan , "linux-kernel@vger.kernel.org" , "Paul E. McKenney" , Thomas Gleixner , "linux-mm@kvack.org" Subject: Re: INFO: possible recursive locking detected: get_partial_node() on 3.2-rc1 In-Reply-To: <20111115072251.GA10389@zhy> Message-ID: References: <20111109090556.GA5949@zhy> <201111102335.06046.kernelmail.jms@gmail.com> <1320980671.22361.252.camel@sli10-conroe> <1321248853.22361.280.camel@sli10-conroe> <20111115072251.GA10389@zhy> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Nov 2011, Yong Zhang wrote: >> Subject: slub: move discard_slab out of node lock >> >> Lockdep reports there is potential deadlock for slub node list_lock. >> discard_slab() is called with the lock hold in unfreeze_partials(), >> which could trigger a slab allocation, which could hold the lock again. >> >> discard_slab() doesn't need hold the lock actually, if the slab is >> already removed from partial list. >> >> Reported-and-tested-by: Yong Zhang >> Reported-and-tested-by: Julie Sullivan >> Signed-off-by: Shaohua Li > > Tested-by: Yong Zhang Applied, thanks!