From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753320Ab1LBT1J (ORCPT ); Fri, 2 Dec 2011 14:27:09 -0500 Received: from mail-qy0-f174.google.com ([209.85.216.174]:58021 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704Ab1LBT1I (ORCPT ); Fri, 2 Dec 2011 14:27:08 -0500 Date: Fri, 2 Dec 2011 14:27:04 -0500 (EST) From: Nicolas Pitre To: =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= cc: Paul Gortmaker , Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: add default value for PHYS_OFFSET Kconfig setting In-Reply-To: <20111202190716.GA4585@pengutronix.de> Message-ID: References: <1322711557-8279-1-git-send-email-paul.gortmaker@windriver.com> <201112011419.46751.arnd@arndb.de> <20111202092124.GR26618@pengutronix.de> <4ED8FD76.3000802@windriver.com> <20111202190716.GA4585@pengutronix.de> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-858183275-1322854026=:2357" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-858183275-1322854026=:2357 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT On Fri, 2 Dec 2011, Uwe Kleine-König wrote: > Hello, > > On Fri, Dec 02, 2011 at 11:31:50AM -0500, Paul Gortmaker wrote: > > On 11-12-02 04:21 AM, Uwe Kleine-König wrote: > > > Hello Nicolas, > > > > > > On Fri, Dec 02, 2011 at 12:33:26AM -0500, Nicolas Pitre wrote: > > > > [...] > > > > >> And it seems that at91x40 is the only defconfig with MMU=n, so the only > > >> option is really to provide a default CONFIG_PHYS_OFFSET. So what about > > >> this: > > >> > > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > >> index e084b7e981..a24672924f 100644 > > >> --- a/arch/arm/Kconfig > > >> +++ b/arch/arm/Kconfig > > >> @@ -222,6 +222,7 @@ config NEED_MACH_MEMORY_H > > >> config PHYS_OFFSET > > >> hex "Physical address of main memory" > > >> depends on !ARM_PATCH_PHYS_VIRT && !NEED_MACH_MEMORY_H > > >> + default DRAM_BASE if !MMU > > >> help > > >> Please provide the physical address corresponding to the > > >> location of main memory in your system. > > >> > > >> Eventually the DRAM_BASE config option could simply be replaced by > > >> PHYS_OFFSET directly, but that's a larger change. > > > I'm working on a MMU-less machine, too and had that change already in my > > > working copy. I was about to commit and it send out later today. > > > > > > So: Acked-by: Uwe Kleine-König > > > > Looks fine to me as well; I had no particular attachment to the > > original patch, and you guys have a much better understanding of > > the specifics of the system. > A post-ack comment: would it make sense to make this: > > config PHYS_OFFSET > hex "Physical address of main memory" if MMU > ... > > such that !MMU build don't get a chance to misconfigure it? Sure. Nicolas --8323328-858183275-1322854026=:2357--