From: Thomas Gleixner <tglx@linutronix.de>
To: Namit Gupta <namit2010@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Removal of unwanted comment in hrtimer structure
Date: Wed, 25 Jan 2012 15:16:21 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1201251512520.2716@ionos> (raw)
In-Reply-To: <CAKMXDJWDx6Zef6yqJjTyCRuhSnkAfcSTEdVoJH+woOqHWttV2w@mail.gmail.com>
On Mon, 23 Jan 2012, Namit Gupta wrote:
> Dear Mr Thomas Gleixner,
>
> While working on hrtimer, I found that the "_expires" field has been
> removed in latest kernel (kernel 3.x). but the comment written for
> "_expires" has yet not been removed.
There is no comment for the _expires field. The comment talks about
node and the struct element node.expires which replaced _expires, but
still has the same semantics as the old _expires field. So the comment
is correct and stays.
> /**
> * struct hrtimer - the basic hrtimer structure
> - * @node: timerqueue node, which also manages node.expires,
> - * the absolute expiry time in the hrtimers internal
> - * representation. The time is related to the clock on
> - * which the timer is based. Is setup by adding
> - * slack to the _softexpires value. For non range timers
> - * identical to _softexpires.
> + * @node: timerqueue node, which also manages node
Aside of that this comment is wrong and pointless. It says:
@A: bla A, which also manages A
Pretty useless.
Thanks,
tglx
parent reply other threads:[~2012-01-25 14:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAKMXDJWDx6Zef6yqJjTyCRuhSnkAfcSTEdVoJH+woOqHWttV2w@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1201251512520.2716@ionos \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=namit2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®