mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, hirofumi@mail.parknet.co.jp,
	linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: hpet_disable() call sites
Date: Tue, 27 Mar 2012 14:58:58 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1203271457460.2542@ionos> (raw)
In-Reply-To: <4F719449020000780007B0CD@nat28.tlf.novell.com>

On Tue, 27 Mar 2012, Jan Beulich wrote:
> up kernel has a problem if the HPET is in an unexpected state, in
> particular preventing "normal" timer interrupts from occurring (which
> was in particular found to be the case during kdump attempts after
> Xen was running).

What's Xen doing special with the hpet ?
 
> Is there any reason why hpet_disable() should not also be called
> from (or some equivalent action be taken, perhaps including clearing
> certain bits in the individual counters' configuration registers, which
> are apparently - but perhaps wrongly - implied to be clear in e.g.
> hpet_set_mode(), in) hpet_enable()?

No, there is no particular reason why we don't clear those registers.

Thanks,

	tglx

  reply	other threads:[~2012-03-27 12:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27  8:19 Jan Beulich
2012-03-27 12:58 ` Thomas Gleixner [this message]
2012-03-27 13:16   ` Jan Beulich
2012-03-27 13:54     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1203271457460.2542@ionos \
    --to=tglx@linutronix.de \
    --cc=JBeulich@suse.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®