mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jiang Liu <liuj97@gmail.com>
Cc: Greg KH <greg@kroah.com>, Jiang Liu <jiang.liu@huawei.com>,
	Keping Chen <chenkeping@huawei.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] IRQ: introduce irq_do_set_affinity() to reduce duplicated code
Date: Thu, 29 Mar 2012 20:55:55 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1203292049400.2542@ionos> (raw)
In-Reply-To: <1333039493-4090-1-git-send-email-jiang.liu@huawei.com>

On Fri, 30 Mar 2012, Jiang Liu wrote:

> Introduce irq_do_set_affinity() to reduce duplicated code.
> This patch also fixes a minor bug in irq_move_masked_irq(),
> which treats return value IRQ_SET_MASK_OK_NOCOPY as error.

Again. Please don't do that.

A bug fix is a bug fix and a cleanup is a cleanup. Mixing both is
simply wrong. It's also completely non obvious from the subject line
that this patch contains a bug fix - minor or not is completely
irrelevant.

The order is bug fix first, then cleanup and improvements. 

Please be more careful about this.

Thanks,

	tglx

  parent reply	other threads:[~2012-03-29 18:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-29 16:44 Jiang Liu
2012-03-29 16:44 ` [PATCH v2 2/3] IRQ,x86: normalize return value of chip->irq_set_affinity() method Jiang Liu
2012-03-29 16:44 ` [PATCH v2 3/3] IRQ,IA64: " Jiang Liu
2012-03-29 18:55 ` Thomas Gleixner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-03-29 16:36 [PATCH v2 0/3] " Jiang Liu
2012-03-29 16:36 ` [PATCH v2 1/3] IRQ: introduce irq_do_set_affinity() to reduce duplicated code Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1203292049400.2542@ionos \
    --to=tglx@linutronix.de \
    --cc=chenkeping@huawei.com \
    --cc=greg@kroah.com \
    --cc=jiang.liu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuj97@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®