Re: [PATCH] rcutree: Fix v3.4-rc2-rt2 build break

[Thomas Gleixner <tglx@linutronix.de>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1238 bytes --]

On Wed, 11 Apr 2012, John Kacur wrote:

> Fix build break of the following types.
> 
> linux-rt/kernel/rcutree_plugin.h: In function ‘print_cpu_stall_fast_no_hz’:
> linux-rt/kernel/rcutree_plugin.h:2195: error: ‘rcu_idle_gp_timer’ undeclared (first use in this function)
> linux-rt/kernel/rcutree_plugin.h:2195: error: (Each undeclared identifier is reported only once
> linux-rt/kernel/rcutree_plugin.h:2195: error: for each function it appears in.)
> 
> The build break only occurs with the PREEMPT_RT_FULL patch applied, however
> the patch is meant to go upstream and be applied to v3.4-rc2 as well because
> it makes the code more legible there, and will reduce the number of places
> where #ifdef PREEMPT_RT_FULL is required should that go upstream someday.

-ENOPARSE

I really have no idea what the patch is solving and which particular
combination of config items is causing the above.

If you think that the patch should go upstream then please send a
separate one with a changelog which explains the simplifcation.

I agree that this ifdef maze can do with simplification, but providing
a changelog which tells nothing at all does not make it easier to grok
the problem and understand what's simplified.

Thanks,

	tglx