From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sasikantha Babu <sasikanth.v19@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [GIT pull] timer fixes for 3.4
Date: Fri, 13 Apr 2012 00:39:34 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1204130037060.2542@ionos> (raw)
In-Reply-To: <CA+55aFzP-DmGUqGcnxj2mq-mvmOXA7k-zgOrdDRY3WA9N5dmBg@mail.gmail.com>
On Thu, 12 Apr 2012, Linus Torvalds wrote:
> On Thu, Apr 12, 2012 at 3:26 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > I ran it through all the various (outdated) distros I have handy and
> > the printk didn't show once.
> >
> > I tried to figure out the reason for this NULL pointer thing, but
> > there is no trace of it on the intarwebs at all.
>
> Ok. If we don't see any reports of messages, we can certainly remove it.
>
> That said, would people actually *report* those messages?
>
> In general, for things like this, it's probably better to just make
> the change (especially if you have several distros you can test), and
> then add a printk_once() for the case that changed. Then, if people
I changed it to a printk_once() already.
> actually report it as some program stopping to work, the dmesg
> hopefully clues us in about the reason for the program not working.
> But that would have needed to happen during the merge window, it's too
> late now.
Yeah, sorry. I queued it and missed to send it along in time, then
queued other real fixes on top of it. Feel free to revert it and i put
it up for 3.5
Thanks,
tglx
next prev parent reply other threads:[~2012-04-12 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 22:06 Thomas Gleixner
2012-04-12 22:19 ` Linus Torvalds
2012-04-12 22:26 ` Thomas Gleixner
2012-04-12 22:31 ` Linus Torvalds
2012-04-12 22:39 ` Thomas Gleixner [this message]
2012-04-12 22:46 ` Linus Torvalds
2012-04-12 23:01 ` Thomas Gleixner
2012-04-26 9:23 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1204130037060.2542@ionos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sasikanth.v19@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®