From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754699Ab2DSJal (ORCPT ); Thu, 19 Apr 2012 05:30:41 -0400 Received: from www.linutronix.de ([62.245.132.108]:38321 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754453Ab2DSJah (ORCPT ); Thu, 19 Apr 2012 05:30:37 -0400 Date: Thu, 19 Apr 2012 11:30:31 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: Matthew Garrett , =?ISO-8859-15?Q?J=F6rg_Otte?= , linux-kernel@vger.kernel.org, Len Brown Subject: Re: [v3.4-rc1] ACPI regression bisected In-Reply-To: <4F872C7B.6000106@linux.intel.com> Message-ID: References: <20120402235412.GD16303@tassilo.jf.intel.com> <20120412142904.GA4130@srcf.ucam.org> <4F872C7B.6000106@linux.intel.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Apr 2012, Andi Kleen wrote: > > > > I feared that. So now is the question whether there is a way to mask > > > the interrupt at the "device" level. > > Probably not. Len? > > > If not, I could be persuaded to provide a mechanism to force thread > > all interrupts which are on that line, if there's a good argument to > > do so. > > Hmm, we could probably just use a work queue for this instead. I guess i drank > the threaded > interrupt kool aid too much when I did the patch :-) > > I'll switch over to a workqueue. That still requires that you can silence the interrupt at the device level in the first place unless you play silly games with disable_irq_nosync(), which is even worse than having a IRQF_FORCE_ONESHOT mechanism in the core. If you go the workqueue way, then you basically split the interrupt into a hard irq context and a thread handler. So it's the same to request a real threaded interrupt with a primary and a thread handler and return IRQF_WAKE_THREAD conditionally from the primary handler, when you need the thread context for further processing. Thoughts? tglx