mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Ning Jiang <ning.n.jiang@gmail.com>
Cc: rjw@sisk.pl, linux-kernel@vger.kernel.org
Subject: Re: add IRQS_PENDING for nested, simple and level handler to early abort suspend operation
Date: Fri, 18 May 2012 09:55:13 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1205180950400.3231@ionos> (raw)
In-Reply-To: <CAH3Oq6Rhqr+cZmYPCOhHqOP=B60zw_GRFDCkOTjEr9wp9NtFmA@mail.gmail.com>

On Fri, 18 May 2012, Ning Jiang wrote:

> During suspend check_wakeup_irqs() will check IRQS_PENDING flag to
> abort a suspend operation, however, this only applies for edge
> triggered irq. Add IRQS_PENDING for nested, simple and level handler
> to mimic the same behaviour as edge irq handler.
> 
> Without this optimization, level irq can be handled correctly but there
> is some penalty. It has to go through a full run/suspend power cycle for level
> irq to be detected and handled. With it, we can abort the suspend operation
> earlier and thus shorten the interrupt latency.
> 
> I know this is ugly as IRQS_PENDING is intended for edge irq but I don't
> know how to do it in a right way. Please enlighten me if you have better ideas.

First of all, please send patches inlined. Aside of that a similar
patch is queued in tip/irq/core commit d4dc0f90.

Thanks,

	tglx



  reply	other threads:[~2012-05-18  7:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18  4:55 Ning Jiang
2012-05-18  7:55 ` Thomas Gleixner [this message]
2012-05-18  9:45   ` Ning Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1205180950400.3231@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ning.n.jiang@gmail.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome