From: Thomas Gleixner <tglx@linutronix.de>
To: Ning Jiang <ning.n.jiang@gmail.com>
Cc: rjw@sisk.pl, linux-kernel@vger.kernel.org
Subject: Re: Add IRQS_PENDING for nested and simple irq handler as well
Date: Tue, 22 May 2012 10:49:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1205221048140.3231@ionos> (raw)
In-Reply-To: <CAH3Oq6S64c9ttsAStn05FTkg+VC0o27Ad4DhHs=b4E7AKjWdjA@mail.gmail.com>
On Tue, 22 May 2012, Ning Jiang wrote:
Please do not top post.
> Sorry that I do not make myself clear.
>
> First, we should keep all the handle_*_irq behave in pretty much the
> same way even just for the beauty of it. Every interrupt disabled in
> suspend operation needs the ability to abort suspend if there is a
> pending irq.
>
> Second, let's take look at a example:
>
> |
> +---------+
> | INTC |
> +---------+
> | GPIO_IRQ
> +------------+
> | gpio-exp |
> +------------+
> | |
> GPIO0_IRQ GPIO1_IRQ
>
> In the above diagram, gpio expander has irq number GPIO_IRQ, it is
> connected with two sub GPIO pins, GPIO0 and GPIO1.
>
> During suspend, normally we want to set IRQF_NO_SUSPEND for GPIO_IRQ
> so that gpio expander driver can handle the sub irq GPIO0_IRQ and
> GPIO1_IRQ, and these two irqs themselves are handled by simple or
> nested irq in some drivers(typically gpio and mfd driver), if they are
> disabled during suspend, we want them to be able to abort suspend too.
Ok, that makes a lot of sense and should be part of the changelog, so
we know in a year from now why we did this change. Care to resend with
a fixed up changelog ?
Thanks,
tglx
next prev parent reply other threads:[~2012-05-22 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 16:48 Ning Jiang
2012-05-21 21:12 ` Thomas Gleixner
2012-05-22 6:00 ` Ning Jiang
2012-05-22 8:49 ` Thomas Gleixner [this message]
2012-05-22 11:14 ` Ning Jiang
2012-05-23 16:02 ` Ning Jiang
2012-05-23 19:04 ` Thomas Gleixner
2012-05-24 7:29 ` Ning Jiang
2012-05-24 20:52 ` [tip:irq/core] genirq: Add IRQS_PENDING for nested and simple irq tip-bot for Ning Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1205221048140.3231@ionos \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ning.n.jiang@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome