From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819Ab2GQIwM (ORCPT ); Tue, 17 Jul 2012 04:52:12 -0400 Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:52662 "EHLO e06smtp18.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754649Ab2GQIwK (ORCPT ); Tue, 17 Jul 2012 04:52:10 -0400 Date: Tue, 17 Jul 2012 10:35:12 +0200 (CEST) From: Sebastian Ott X-X-Sender: sebott@c4eb To: Ming Lei cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] driver core: move uevent call to driver_register In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) Organization: =?ISO-8859-15?Q?=22IBM_Deutschland_Research_&_Development_GmbH_=2F_Vorsitzende_des_Aufsichtsrats=3A_Martina_Koederitz_Gesch=E4ftsf=FChrung=3A_Dirk_Wittkopp_Sitz_der_Gesellschaft=3A_B=F6blingen_=2F_Registergericht?= =?ISO-8859-15?Q?=3A_Amtsgericht_Stuttgart=2C_HRB_243294=22?= MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII x-cbid: 12071708-6892-0000-0000-000002747A13 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, 17 Jul 2012, Ming Lei wrote: > On Tue, Jul 3, 2012 at 1:08 AM, Sebastian Ott wrote: > > > --- a/drivers/base/driver.c > > +++ b/drivers/base/driver.c > > @@ -187,6 +187,9 @@ int driver_register(struct device_driver > > ret = driver_add_groups(drv, drv->groups); > > if (ret) > > bus_remove_driver(drv); > > + > > + kobject_uevent(&drv->p->kobj, KOBJ_ADD); > > You should just send the uevent if 'ret' equals to zero., otherwise > OOPS may be triggered by kobject_uevent() after the 'drv' has been > removed. oh..sorry. Missed that. Thanks for catching it! Updated Patch: [PATCH] driver core: move uevent call to driver_register Device driver attribute groups are created after userspace is notified via an add event. Fix this by moving the kobject_uevent call to driver_register after the attribute groups are added. Signed-off-by: Sebastian Ott --- drivers/base/bus.c | 1 - drivers/base/driver.c | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -743,7 +743,6 @@ int bus_add_driver(struct device_driver } } - kobject_uevent(&priv->kobj, KOBJ_ADD); return 0; out_unregister: --- a/drivers/base/driver.c +++ b/drivers/base/driver.c @@ -185,8 +185,12 @@ int driver_register(struct device_driver if (ret) return ret; ret = driver_add_groups(drv, drv->groups); - if (ret) + if (ret) { bus_remove_driver(drv); + return ret; + } + kobject_uevent(&drv->p->kobj, KOBJ_ADD); + return ret; } EXPORT_SYMBOL_GPL(driver_register);