mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the final tree (slab tree related)
Date: Wed, 19 Sep 2012 09:57:58 +0300 (EEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1209190957330.2390@tux.localdomain> (raw)
In-Reply-To: <00000139b6e13c92-97adf129-be2c-4b74-9559-0a92c10b9eda-000000@email.amazonses.com>

On Tue, 11 Sep 2012, Christoph Lameter wrote:

> On Tue, 11 Sep 2012, Stephen Rothwell wrote:
> 
> > After merging the final tree, today's linux-next build (sparc64 defconfig)
> > produced this warning:
> >
> > mm/slab.c:808:13: warning: '__slab_error' defined but not used [-Wunused-function]
> >
> > Introduced by commit 945cf2b6199b ("mm/sl[aou]b: Extract a common function for kmem_cache_destroy").  All uses of slab_error() are now guarded by DEBUG.
> 
> 
> Subject: Slab: Only define slab_error for DEBUG
> 
> There is no use case left for slab builds without DEBUG.
> 
> Signed-off-by: Christoph Lameter <cl@linux.com>
> 
> Index: linux/mm/slab.c
> ===================================================================
> --- linux.orig/mm/slab.c	2012-09-11 14:44:56.304015235 -0500
> +++ linux/mm/slab.c	2012-09-11 14:48:46.988948440 -0500
> @@ -803,6 +803,7 @@ static void cache_estimate(unsigned long
>  	*left_over = slab_size - nr_objs*buffer_size - mgmt_size;
>  }
> 
> +#if DEBUG
>  #define slab_error(cachep, msg) __slab_error(__func__, cachep, msg)
> 
>  static void __slab_error(const char *function, struct kmem_cache *cachep,
> @@ -812,6 +813,7 @@ static void __slab_error(const char *fun
>  	       function, cachep->name, msg);
>  	dump_stack();
>  }
> +#endif
> 
>  /*
>   * By default on NUMA we use alien caches to stage the freeing of
> 

Applied, thanks.

P.S. Guys, please use penberg@kernel.org email address. I missed this 
patch because I don't read this mailbox.

			Pekka

  reply	other threads:[~2012-09-19  6:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11  6:19 Stephen Rothwell
2012-09-11 19:49 ` Christoph Lameter
2012-09-19  6:57   ` Pekka Enberg [this message]
2012-09-19  7:22     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1209190957330.2390@tux.localdomain \
    --to=penberg@kernel.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®