From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932323Ab2IURk0 (ORCPT ); Fri, 21 Sep 2012 13:40:26 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:36662 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932122Ab2IURkY (ORCPT ); Fri, 21 Sep 2012 13:40:24 -0400 Date: Fri, 21 Sep 2012 13:40:22 -0400 (EDT) From: Nicolas Pitre To: Cyril Chemparathy cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, catalin.marinas@arm.com, grant.likely@secretlab.ca, linux@arm.linux.org.uk, will.deacon@arm.com Subject: Re: [PATCH v3 02/17] ARM: add self test for runtime patch mechanism In-Reply-To: <1347385155-11643-3-git-send-email-cyril@ti.com> Message-ID: References: <1347385155-11643-1-git-send-email-cyril@ti.com> <1347385155-11643-3-git-send-email-cyril@ti.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Sep 2012, Cyril Chemparathy wrote: > This patch adds basic sanity tests to ensure that the instruction patching > results in valid instruction encodings. This is done by verifying the output > of the patch process against a vector of assembler generated instructions at > init time. > > Signed-off-by: Cyril Chemparathy > --- > arch/arm/Kconfig | 12 +++++++ > arch/arm/kernel/runtime-patch.c | 75 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 87 insertions(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 36de4ea..bfcd29d 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -207,6 +207,18 @@ config ARM_PATCH_PHYS_VIRT > this feature (eg, building a kernel for a single machine) and > you need to shrink the kernel to the minimal size. > > +config ARM_RUNTIME_PATCH_TEST > + bool "Self test runtime patching mechanism" if ARM_RUNTIME_PATCH > + default y Here you probably want this instead: bool "Self test runtime patching mechanism" default y depends on ARM_RUNTIME_PATCH Otherwise ARM_RUNTIME_PATCH_TEST will be forced to y whenever ARM_RUNTIME_PATCH is unset. That doesn't currently affect the build since the containing .c file is only compiled when ARM_RUNTIME_PATCH is set but that is still not strictly right. [...] > @@ -189,5 +261,8 @@ void __init runtime_patch_kernel(void) > const void *start = &__runtime_patch_table_begin; > const void *end = &__runtime_patch_table_end; > > +#ifdef CONFIG_ARM_RUNTIME_PATCH_TEST > + runtime_patch_test(); > +#endif > BUG_ON(runtime_patch(start, end - start)); I think you shoulld have runtime_patch_test() return a possible error code and use BUG_ON() with it as well. With those minor changes you can add... Reviewed-by: Nicolas Pitre Nicolas