From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754712Ab3A3VC6 (ORCPT ); Wed, 30 Jan 2013 16:02:58 -0500 Received: from relais.videotron.ca ([24.201.245.36]:62420 "EHLO relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486Ab3A3VC4 (ORCPT ); Wed, 30 Jan 2013 16:02:56 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: TEXT/PLAIN; CHARSET=US-ASCII Date: Wed, 30 Jan 2013 16:02:54 -0500 (EST) From: Nicolas Pitre To: Matt Sealey Cc: Ruslan Bilovol , Linux ARM Kernel ML , linux-omap@vger.kernel.org, LKML , tony@atomide.com, Russell King - ARM Linux , eduardo.valentin@ti.com Subject: Re: [RFC PATCH v3 1/2] ARM: kernel: update cpuinfo to print SoC model name In-reply-to: Message-id: References: <1359558091-29251-1-git-send-email-ruslan.bilovol@ti.com> <1359558091-29251-2-git-send-email-ruslan.bilovol@ti.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jan 2013, Matt Sealey wrote: > On Wed, Jan 30, 2013 at 1:07 PM, Nicolas Pitre wrote: > > On Wed, 30 Jan 2013, Ruslan Bilovol wrote: > > > >> Currently, reading /proc/cpuinfo provides userspace with CPU ID of > >> the CPU carrying out the read from the file. > >> Userspace using this information may decide what module > >> to load or how to configure some specific (and processor-depended) > >> settings or so. > >> However, since really different SoCs can share same ARM core, > >> this information currently is not so useful. > >> For example, TI OMAP4460 and OMAP4470 SoCs show the same > >> information in the /proc/cpuinfo whereas they are different. > >> Since in most cases ARM CPU is a part of some system on a chip (SoC), > >> the "cpuinfo" file looks like exactly that place, where this > >> information have to be displayed. > >> > >> So added new line "SoC name" in the "cpuinfo" output for system > >> on a chip name. It is placed between CPU information and machine > >> information, so the file structure looks gracefully (CPU-SoC-Hardware) > >> > >> Example: > >> > >> / # cat proc/cpuinfo > >> [...] > >> CPU variant : 0x2 > >> CPU part : 0xc09 > >> CPU revision : 10 > >> > >> SoC name : OMAP4470 > >> > >> Hardware : OMAP4 Blaze Tablet > > > > Please remove that extra blank line between "SoC name" and "Hardware". > > The blank line after "CPU revision" is fine. > > > > Also, please rename this to "System name". Not all systems are "on > > chip". By using "System name" this is more universally useful. > > I can't agree with "System name", it is confusing in common > terminology since it's about the same definition as the current > "Hardware" line. > > If we're just printing out the name of the device surrounding the CPU > - be it a Northbridge/Southbridge combination or SoC packaging - > "Chipset" might be a better name for it. That suits me as well. Nicolas