mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Raphael S.Carvalho" <raphael.scarv@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jarkko Sakkinen <jarkko.sakkinen@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arch/x86/smpboot.c: Fix GCC Warning (unused variable)!
Date: Tue, 5 Mar 2013 23:02:09 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.02.1303052257060.22263@ionos> (raw)
In-Reply-To: <1362508625-7803-1-git-send-email-raphael.scarv@gmail.com>

On Tue, 5 Mar 2013, Raphael S.Carvalho wrote:

> GCC complained about the unused variable c, thus I'm sending
> this patch in order to calm it down.
> I compiled the file and everything seems be ok!

What is your patch solving? How about removing the line completely?
And how about providing a changelog which makes sense ?

Thanks,

	tglx
 
> Signed-off-by: Raphael S.Carvalho <raphael.scarv@gmail.com>
> ---
>  arch/x86/kernel/smpboot.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index a6ceaed..77a5616 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1367,7 +1367,7 @@ static inline void mwait_play_dead(void)
>  	unsigned int highest_subcstate = 0;
>  	int i;
>  	void *mwait_ptr;
> -	struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
> +	__this_cpu_ptr(&cpu_info);
>  
>  	if (!this_cpu_has(X86_FEATURE_MWAIT))
>  		return;
> -- 
> 1.7.2.5
> 
> 

  reply	other threads:[~2013-03-05 22:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 18:37 Raphael S.Carvalho
2013-03-05 22:02 ` Thomas Gleixner [this message]
2013-03-05 22:08   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1303052257060.22263@ionos \
    --to=tglx@linutronix.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=jarkko.sakkinen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=raphael.scarv@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome