From: Thomas Gleixner <tglx@linutronix.de>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] timekeeping: handle epoch roll-over (2038) on 32-bit systems
Date: Fri, 7 Jun 2013 22:57:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1306072248430.24812@ionos> (raw)
In-Reply-To: <20130604065947.GA10895@gmail.com>
Tobias,
On Tue, 4 Jun 2013, Tobias Waldekranz wrote:
> On Mon, Jun 03, 2013 at 04:34:25PM +0200, Thomas Gleixner wrote:
> > Just "fixing" some random parts of the code in a "make it work
> > somehow" way is a pointless exercise IMO.
> >
> Now hold on, it is hardly random. On an ARM system, the kernel will
> completely hang. I would think that many users would like to avoid
> that. In addition this behavior is rather new, hrtimer_interrupt used
> to source its time from ktime_get which avoids this issue. The change
> was introduced in:
>
> 5baefd6d84163443215f4a99f6a20f054ef11236
>
> I understand that you would like a solution to the broader issue. But
> for some users (embedded especially) having a system that continues to
> operate 25 years from now is an issue today.
>
> As for "make it work somehow", modifying the current time calculation
> to work in the same way as in ktime_get does seem to be a reasonable
> way to go IMO.
No, it's not. You are "fixing" something which is not fixable by
definition. There is no rule to prevent similar borkage tomorrow.
You are just band aiding a singular instance of a massive problem
which has an already known root cause.
If you really care about your system working in 25 years from now with
the kernel of today then you rather should sit down and fix it proper.
Your "fix" merily allows the system to boot, but its broken beyond
repair aside of that. So what's the point?
If we do not tackle the underlying issues, then your machine will be
rendered completely useless with or without your patch. It's that
simple. So don't try to sell me a bandaid hack as a reasonable way to
go.
Thanks,
tglx
prev parent reply other threads:[~2013-06-07 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:34 Tobias Waldekranz
2013-06-03 14:34 ` Thomas Gleixner
2013-06-03 19:04 ` John Stultz
2013-06-07 21:53 ` Thomas Gleixner
2013-06-20 12:34 ` Ingo Molnar
2013-08-24 23:47 ` Michael Gilbert
2013-06-04 6:59 ` Tobias Waldekranz
2013-06-07 20:57 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1306072248430.24812@ionos \
--to=tglx@linutronix.de \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome