From: John Kacur <jkacur@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: John Kacur <jkacur@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>,
John Kacur <jkacur@gmail.com>, Clark Williams <clark@redhat.com>
Subject: Re: [RFC][PATCH RT] acpi/rt: Convert acpi lock back to a raw_spinlock_t
Date: Wed, 13 Feb 2013 18:46:50 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.03.1302131844530.13701@tycho> (raw)
In-Reply-To: <alpine.LFD.2.02.1302131755230.11905@ionos>
On Wed, 13 Feb 2013, Thomas Gleixner wrote:
> On Wed, 13 Feb 2013, John Kacur wrote:
> >
> > Thanks Steven. That looks way better than the previous revert.
>
> I can't tell as I haven't seen the previous revert. And looks good is
> not really a good review criteria.
Absolutely true, and I wasn't claiming to have reviewed it, just wanted to
let everyone know that testing on it was to begin.
>
> The patch is converting _all_ the spin_locks in acpi to raw spinlocks,
> which will give you a nice bunch of "BUG: sleeping function called
> from invalid context" splats depending on the ACPI functionality of
> your machine.
>
> The lock which is related to this splat is: acpi_gbl_hardware_lock and
> that's the only lock which can be safely converted to a raw spinlock.
>
> Untested patch below.
>
> Thanks,
>
> tglx
Thank you Thomas, adding this version instead to our test queue.
John
-----------------SNIP
next prev parent reply other threads:[~2013-02-13 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 14:26 Steven Rostedt
2013-02-13 16:42 ` Thomas Gleixner
2013-02-13 16:46 ` John Kacur
2013-02-13 17:21 ` Thomas Gleixner
2013-02-13 17:46 ` John Kacur [this message]
2013-02-13 17:51 ` Steven Rostedt
2013-02-13 18:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1302131844530.13701@tycho \
--to=jkacur@redhat.com \
--cc=clark@redhat.com \
--cc=jkacur@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®