From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Rob Herring <robherring2@gmail.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
Will Deacon <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 2/2] arm: prefer PSCI for SMP bringup
Date: Mon, 1 Apr 2013 14:20:44 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.03.1304011412030.1171@syhkavp.arg> (raw)
In-Reply-To: <alpine.DEB.2.02.1304011541010.5078@kaball.uk.xensource.com>
On Mon, 1 Apr 2013, Stefano Stabellini wrote:
> On Fri, 29 Mar 2013, Rob Herring wrote:
> > On 03/29/2013 12:53 PM, Nicolas Pitre wrote:
> > > On Fri, 29 Mar 2013, Stefano Stabellini wrote:
> > >
> > >> On Fri, 29 Mar 2013, Nicolas Pitre wrote:
> > >>> On Fri, 29 Mar 2013, Stefano Stabellini wrote:
> > >>>
> > >>>> If PSCI initializes correctly and PSCI SMP operations are available, use them.
> > >>>> This is required for SMP support in Dom0 on Xen.
> > >>>>
> > >>>> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > >>>> CC: will.deacon@arm.com
> > >>>> CC: arnd@arndb.de
> > >>>> CC: marc.zyngier@arm.com
> > >>>> CC: linux@arm.linux.org.uk
> > >>>> CC: nico@linaro.org
> > >>>
> > >>> I'd suggest you also include in your series the patch I posted earlier
> > >>> providing a runtime mdesc->smp_init method as well.
> > >>
> > >> OK.
> > >>
> > >>
> > >>> This way the
> > >>> priority order would be:
> > >>>
> > >>> - If mdesc->smp_init is non null then use that.
> > >>>
> > >>> - Otherwise, if PSCI is available then use that.
> > >>>
> > >>> - Otherwise use mdesc->smp.
> > >>>
> > >>> This way, if the PSCI default has to be overriden (like in the MCPM case
> > >>> because it needs to wrap PSCI itself, or to cover Rob's concern) then
> > >>> this can be achieved at run time on a per mdesc basis.
> > >>
> > >> Actually that's not a bad idea, it could make everybody happy.
> > >> What about the following, in this precise order:
> > >>
> > >> - if a xen hypervisor node is present on device tree, use PSCI;
> > >> - otherwise if mdesc->smp_init is non null then use it;
> > >> - otherwise if PSCI is available then use it;
> > >> - otherwise use mdesc->smp.
> > >>
> > >> It's the most practical solution to satisfy everybody's needs.
> > >
> > > Maybe I'm missing something obvious, but why can't xen declare a mdesc
> > > of its own? Given it is going to tweak the DT passed to the kernel
> > > anyway that shouldn't be a problem.
> >
> > Xen does have it's own mdesc. It is (or will be) mach-virt, but that is
> > only for DomU guests. For Dom0, you still need all the platform specific
> > code except smp_ops. However, I'm doubtful this would work without other
> > changes on more complicated platforms like OMAP.
> >
> > I would say wait to add this until you have platforms that actually need
> > the first case.
>
> OK, that is not unreasonable.
>
> What are the platforms that are going to use smp_init? Do we know how do
> they intend to use it?
VExpress for one. When booting on a big.LITTLE system such as TC2 on
VExpress, the MCPM layer needs to arbitrate power management operations
on a per cluster basis. In that case there is a MCPM specific set of
SMP ops to be used, even if it may end up calling into PSCI.
But the important point is that we don't know beforehand what to use,
especially with a kernel that can boot on multiple different VExpress
configurations. The decision has to be made at run time, and therefore
a static default or mdesc->smp ops doesn't cut it.
Nicolas
next prev parent reply other threads:[~2013-04-01 18:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 16:42 Stefano Stabellini
2013-03-29 17:31 ` Nicolas Pitre
2013-03-29 17:38 ` Stefano Stabellini
2013-03-29 17:53 ` Nicolas Pitre
2013-03-29 18:07 ` Stefano Stabellini
2013-03-29 19:31 ` Rob Herring
2013-04-01 14:42 ` Stefano Stabellini
2013-04-01 18:20 ` Nicolas Pitre [this message]
2013-04-02 14:28 ` Stefano Stabellini
2013-04-02 16:11 ` Nicolas Pitre
2013-04-09 12:21 ` Dave Martin
2013-04-09 18:34 ` Nicolas Pitre
2013-03-29 18:04 ` Nicolas Pitre
2013-03-29 18:10 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1304011412030.1171@syhkavp.arg \
--to=nicolas.pitre@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=robherring2@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®