From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Dave Martin <dave.martin@linaro.org>
Subject: Re: [PATCH] drivers/bus: arm-cci: fix combined ARMv6+v7 build
Date: Mon, 3 Jun 2013 09:23:58 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.03.1306030922380.1200@syhkavp.arg> (raw)
In-Reply-To: <2485806.Uv8bUctxav@wuerfel>
On Mon, 3 Jun 2013, Arnd Bergmann wrote:
> When we build a kernel with support for both ARMv6 and ARMv7,
> gas is trying to be helpful by pointing out that the arm-cci
> driver would not work on ARMv6:
>
> /tmp/ccu1LDeU.s: Assembler messages:
> /tmp/ccu1LDeU.s:450: Error: selected processor does not support ARM mode `wfi '
> /tmp/ccu1LDeU.s:451: Error: selected processor does not support ARM mode `wfe '
> make[4]: *** [drivers/bus/arm-cci.o] Error 1
>
> We know that the driver will only be used on ARMv7, hence we
> can annotate the inline assembly listing to allow those instructions.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Nicolas Pitre <nico@linaro.org>
> Cc: Dave Martin <dave.martin@linaro.org>
Acked-by: Nicolas Pitre <nico@linaro.org>
Since this code is merged into ARM-SOC, I assume you'll take care of
this patch?
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 380319e..7332889 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -253,7 +253,7 @@ EXPORT_SYMBOL_GPL(cci_disable_port_by_cpu);
> asmlinkage void __naked cci_enable_port_for_self(void)
> {
> asm volatile ("\n"
> -
> +" .arch armv7-a\n"
> " mrc p15, 0, r0, c0, c0, 5 @ get MPIDR value \n"
> " and r0, r0, #"__stringify(MPIDR_HWID_BITMASK)" \n"
> " adr r1, 5f \n"
>
next prev parent reply other threads:[~2013-06-03 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:18 Arnd Bergmann
2013-06-03 13:23 ` Nicolas Pitre [this message]
2013-06-03 13:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1306030922380.1200@syhkavp.arg \
--to=nicolas.pitre@linaro.org \
--cc=arnd@arndb.de \
--cc=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®