From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Isamu Mogi <isamu@leafytree.jp>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: R3000: Fix debug output for Virtual page number
Date: Mon, 29 Sep 2014 01:53:08 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.11.1409290145370.21156@eddie.linux-mips.org> (raw)
In-Reply-To: <1410278429-8541-1-git-send-email-isamu@leafytree.jp>
On Wed, 10 Sep 2014, Isamu Mogi wrote:
> Virtual page number of R3000 in entryhi is 20 bit from MSB. But in
> dump_tlb(), the bit mask to read it from entryhi is 19 bit (0xffffe000).
> The patch fixes that to 0xfffff000.
>
> Signed-off-by: Isamu Mogi <isamu@leafytree.jp>
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
It would be good to add appropriate macros to <asm/mipsregs.h> too, to
avoid magic numbers and decrease the likelihood of issues like this. As a
separate change, that is, of course, and not a prerequisite.
Maciej
next prev parent reply other threads:[~2014-09-29 0:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 16:00 Isamu Mogi
2014-09-29 0:53 ` Maciej W. Rozycki [this message]
2014-10-30 13:07 ` [PATCH v2 0/3] " Isamu Mogi
2014-10-30 13:07 ` [PATCH v2 1/3] " Isamu Mogi
2014-10-30 16:10 ` Ralf Baechle
2014-10-30 13:07 ` [PATCH v2 2/3] MIPS: R3000: Replace magic numbers with macros Isamu Mogi
2014-10-30 13:07 ` [PATCH v2 3/3] MIPS: R3000: Remove redundant parentheses Isamu Mogi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1409290145370.21156@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=isamu@leafytree.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome