From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Thibaut Robert <thibaut.robert@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tc: fix warning and coding style
Date: Tue, 30 Sep 2014 17:28:08 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.11.1409301720050.21156@eddie.linux-mips.org> (raw)
In-Reply-To: <1412079396-26005-1-git-send-email-thibaut.robert@gmail.com>
On Tue, 30 Sep 2014, Thibaut Robert wrote:
> Fix checkpatch warnings:
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
> WARNING: Possible unnecessary 'out of memory' message
> WARNING: quoted string split across lines
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
>
> Fix gcc warning:
> warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘resource_size_t’ [-Wformat=]
>
> As resource_size_t can be 32 or 64 bits (depending on CONFIG_RESOURCES_64BIT), this patch uses "%lld" format along with a cast to u64 for printing resource_size_t values
>
> Signed-off-by: Thibaut Robert <thibaut.robert@gmail.com>
> ---
NAK. These issues have already been taken care of via the LMO tree; the
original change has been archived here:
http://www.linux-mips.org/cgi-bin/mesg.cgi?a=linux-mips&i=alpine.LFD.2.11.1404062030280.15266%40eddie.linux-mips.org
and is on the way to Linus's tree (IIUC; Ralf, please acknowledge).
If you think there's anything wrong still left afterwards, except from
the message wrapping (as I'm not going to approve any modification to go
beyond 79 columns; this is nonsense), then please send an incremental
change on top of that.
Thanks for your contribution anyway.
Maciej
prev parent reply other threads:[~2014-09-30 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 12:16 Thibaut Robert
2014-09-30 12:28 ` Geert Uytterhoeven
2014-09-30 13:51 ` Thibaut Robert
2014-09-30 14:08 ` Geert Uytterhoeven
2014-09-30 14:31 ` Thibaut Robert
2014-09-30 16:28 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1409301720050.21156@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=thibaut.robert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®