From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, David Rientjes <rientjes@google.com>,
Oren Twaig <oren@scalemp.com>, Jan Beulich <JBeulich@suse.com>,
Christoph Lameter <cl@linux.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
linux-kernel@vger.kernel.org,
David Vrabel <david.vrabel@citrix.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2] x86/devicetree: Fix build for amd64
Date: Mon, 2 Feb 2015 18:36:55 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.11.1502021834490.22715@eddie.linux-mips.org> (raw)
In-Reply-To: <1422894601-30318-1-git-send-email-ricardo.ribalda@gmail.com>
On Mon, 2 Feb 2015, Ricardo Ribalda Delgado wrote:
> apic_force_enable is not defined for amd64.
>
> Without this patch:
>
> LD init/built-in.o
> arch/x86/built-in.o: In function `dtb_lapic_setup':
> kernel/devicetree.c:155:
> undefined reference to `apic_force_enable'
> Makefile:923: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>
> v2: Suggested by: Jiang Liu <jiang.liu@linux.intel.com>
>
> How about defining a version of apic_force_enable()
> for X86_64 in apic.h which just return failure?
>
> arch/x86/kernel/apic/apic.c | 6 ++++++
> 1 file changed, 6 insertions(+)
I think the original suggestion made sense, move your stuff to apic.h so
that the call is optimised away rather than keeping it here.
Maciej
prev parent reply other threads:[~2015-02-02 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 16:30 Ricardo Ribalda Delgado
2015-02-02 18:36 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1502021834490.22715@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=JBeulich@suse.com \
--cc=cl@linux.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oren@scalemp.com \
--cc=ricardo.ribalda@gmail.com \
--cc=rientjes@google.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®