From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965546AbbBCLpu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Feb 2015 06:45:50 -0500
Received: from eddie.linux-mips.org ([148.251.95.138]:41850 "EHLO
	cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964889AbbBCLpr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Feb 2015 06:45:47 -0500
Date: Tue, 3 Feb 2015 11:45:44 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
cc: Jiang Liu <jiang.liu@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        David Rientjes <rientjes@google.com>, Oren Twaig <oren@scalemp.com>,
        Jan Beulich <JBeulich@suse.com>, Christoph Lameter <cl@linux.com>,
        Jan Kiszka <jan.kiszka@siemens.com>, linux-kernel@vger.kernel.org,
        David Vrabel <david.vrabel@citrix.com>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3] x86/devicetree: Fix build for amd64
In-Reply-To: <1422905231-16067-1-git-send-email-ricardo.ribalda@gmail.com>
Message-ID: <alpine.LFD.2.11.1502031145030.22715@eddie.linux-mips.org>
References: <1422905231-16067-1-git-send-email-ricardo.ribalda@gmail.com>
User-Agent: Alpine 2.11 (LFD 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2 Feb 2015, Ricardo Ribalda Delgado wrote:

> apic_force_enable is not defined for amd64.
> 
> Without this patch:
> 
> LD      init/built-in.o
> arch/x86/built-in.o: In function `dtb_lapic_setup':
> kernel/devicetree.c:155:
> undefined reference to `apic_force_enable'
> Makefile:923: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> v3: Suggested by: Maciej W. Rozycki <macro@linux-mips.org>
> Implementing the function in apic.h and not in apic.c
> (actually, doing v2 properly :) )
> 
> v2: Suggested by: Jiang Liu <jiang.liu@linux.intel.com>
> 
> How about defining a version of apic_force_enable()
> 	for X86_64 in apic.h which just return failure?

Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>

 Thanks,

  Maciej